search

CareSet / DURC

DURC is reverse CRUD
MIT License
3 stars 2 forks source link

Default Null fields and null checkbox require unchecking null to write #74

Closed ftrotter closed 3 years ago

ftrotter commented 4 years ago

The field should not be unwritable unless the 'null' is unchecked. It should be writeable, and by writing in it... the null gets unchecked.

After writing in the text area... checking the null should popup a prompt that says "are you sure you want to erase what you have written but setting this field to null".

The current system works well enough, it just feels clumsy

kchapple commented 3 years ago

@ftrotter This has been done. Now you can just click in the text box to unlock the field.

Screen Shot 2020-09-22 at 1 27 16 PM
ftrotter commented 3 years ago

Excellent! I am assigning to @seanccsmith to review!

seanccsmith commented 3 years ago

@kchapple this is not working in LoreCommander. When I click the field, it does not allow me to write without first unticking the NULL box. I also can't make the pop-up appear.

kchapple commented 3 years ago

@seanccsmith the view doesn't have the new javascript. You may need to run mine and write

kchapple commented 3 years ago

Sorry, @seanccsmith I didn't check in the new models, controllers and views when I did these changes.

seanccsmith commented 3 years ago

@kchapple have they been checked in now? I ran a git pull on my DURC instance and then ran durc.php, but I'm not getting any different results.

seanccsmith commented 3 years ago

With the updated code, selecting a text box automatically unticks the null tickbox, and ticking it again prompts the pop-up.