CareSet / Zermelo

PHP/MySQL Reporting Engine designed for Laravel
GNU Affero General Public License v3.0
13 stars 4 forks source link

Multiple errors related to php 7.4 and laravel 7 #116

Open ftrotter opened 4 years ago

ftrotter commented 4 years ago

TreePresenter (which is not something that we need to support) and other things are generating the psr-4 loading standards for composer commands etc etc..

Need to test Zermelo and ensure that it also works correctly with both Laravel 6 (which is LTS) and Laravel 7..

-FT

kchapple commented 4 years ago

1- I fixed the crash in the installer.

2- The abandoned package warnins cannot be helped at this time because they are dependencies of Laravel:

Package jakub-onderka/php-console-color is abandoned See: https://laracasts.com/discuss/channels/laravel/package-abandoned-how-to-remove-it

3- @ftrotter TreePresenter had the Card namespace. Changed to Tree to match the PSR-4 directory mapping. The warning is now gone. This module should probably be reworked since I moved away from the presenter pattern and used the report class itself as presenter.

seanccsmith commented 4 years ago

This one's a doozy. Trying to update to Laravel 7, I found I needed to update to symfony 5. I ran a composer update to try to do that, without changing anything in composer.json since nothing in there explicitly requires symfony. I'm not sure this was the correct course of action, as while it did pull a bunch of updates, they all seem to be for symfony 4.4 (screenshot). Another problem seems to have been uncovered, as well, that's more to do with zermelo (same screenshot). Is this a systemic problem, or could it be due somehow to the symlink in my own environment?

Screen Shot 2020-05-12 at 5 05 54 PM

seanccsmith commented 4 years ago

I decided to try to move forward by ignoring the above and seeing if I could get some positive action. After changing composer.json to require "laravel/framework": "^7.0" and "phpunit/phpunit": "^8.5", I ran composer update and got the following errors (3 screenshots):

Screen Shot 2020-05-12 at 5 13 25 PM

Screen Shot 2020-05-12 at 5 13 34 PM

Screen Shot 2020-05-12 at 5 13 44 PM

Deleting the lock file does not help, nor does running composer install rather than composer update, nor does trying to update only laravel.

kchapple commented 4 years ago

@seanccsmith I changed the declaration for some of the installer class attributes to static so they could be accessed without instantiating the class, but this error shouldn’t happen, unless you have the old version of Zermelo, mixed with new version of zermelobladetabular. Try running deleting composer.lock, delete vendor directory and run ‘composer clearcache’ ... then run ‘composer install’