async_urequests should respect content length header

Carglglz / asyncmd

Tools for MicroPython Async Development

7 stars 2 forks source link

async_urequests should respect content length header #1

Closed GM-Script-Writer-62850 closed 1 year ago

GM-Script-Writer-62850 commented 1 year ago

Line 21 of async_urequests.py

self._cached = await self.raw.read()

There exist a upstream bug and a pull request

Carglglz commented 1 year ago

That makes sense, since upstream urequests.py was the reference. Did you test that PR? If that works I could push the changes or accept a PR 👍🏼

GM-Script-Writer-62850 commented 1 year ago

I have not tested it in async_urequests yet, i was just looking over the code and i checked to see if the issue i found before looked to be present in this port

that PR is based on a patch i put in the bug report

GM-Script-Writer-62850 commented 1 year ago

I just confirmed the issue and that the patch i posted in the bug report works

BTW i ended up removing ssl support as micropython asyncio.open_connection only supports 2 arguments

Carglglz commented 1 year ago

I will update async_requests.py then,

BTW i ended up removing ssl support as micropython asyncio.open_connection only supports 2 arguments

Yes asyncio+tls isn't supported yet in MicroPython, it is still in PR state 👍🏼 and it is in async_requests.py to tests those PRs

[EDIT] done in c26c4127ff88c754869836dfaf3522bf1711b703