search

CargoSense / dart_sass

Install and run Dart Sass using Elixir.
https://hex.pm/packages/dart_sass
MIT License
102 stars 23 forks source link

Auto recompiles the CSS doesn't work on DartSASS version 1.51.0 #26

Closed andyduong1920 closed 2 years ago

andyduong1920 commented 2 years ago

Hi, thanks for this library, it helps to integrate DartSASS to Phoenix much easy 💜

Issue

I'm noticed that the auto recompiles the CSS doesn't work on the DartSASS 1.51.0, it also happens on 1.50.0 and 1.50.1

That feature is working well on 1.49.11 FYI.

As I have checked on the DartSASS release changelogs, could it be related to https://github.com/sass/dart-sass/pull/1411 🤔

Step to reproduce

1/ Generate a new Phoenix 1.6.x project 2/ Add DartSASS following the README 3/ Tested with the 1.49.11 version by adjusting the app.css, the new CSS should be written in priv folder and the browser is reloaded 4/ Change the version to 1.50.0 or 1.51.0, adjust the app.css the output CSS file in priv folder didn't update.

Screencast

mcrumm commented 2 years ago

Hi @andyduong1920– unfortunately you are correct. There's a bug in 1.50+ that causes sass with --watch to exit immediately if opened by another program. I have an in-progress fix but it's not quite ready to merge. You can follow progress on the other PR:

mcrumm commented 2 years ago

The vendor package has moved ahead several versions and we have updated our default version past the broken 1.50 release, so this should be less of an issue now :)