search

CargoSense / dart_sass

Install and run Dart Sass using Elixir.
https://hex.pm/packages/dart_sass
MIT License
102 stars 23 forks source link

Updated Sass version to 1.61.0 #31

Closed azizk closed 1 year ago

azizk commented 1 year ago

The Linux package structure has changed and also has two binaries in the src/ folder now. dart-sass 1.57.1 was the last version that you could configure for :dart_sass on Linux.

With my changes you can use newer versions, but you won't be able to use earlier versions anymore.

I refactored the code somewhat for improvements and better readability. I'll revert specific changes if you don't like some. :slightly_smiling_face:

mcrumm commented 1 year ago

Hi @azizk, thanks for the PR! Can you please revert any changes other than those required to get dart_sass running on Linux again? That will make it much easier to review, thanks! If it's easier to close this PR and open a new one, that is fine too :)

azizk commented 1 year ago

Sure, np! 😀

azizk commented 1 year ago

Hey @mcrumm, I extracted the unrelated refactorings from this branch and I'll make a different PR for those. Hope it's easier to review now. :slightly_smiling_face:

azizk commented 1 year ago

Hi @mcrumm, hope you're not too busy. Any chance this can be merged in today or tomorrow? Thanks! :smiley:

mcrumm commented 1 year ago

🍬 🍬 🍬 🍬 🍬