search

CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
751 stars 197 forks source link

Some improvements on xcp commands discovery #108

Open giudasg opened 6 months ago

giudasg commented 6 months ago

Hello. I added some improvements on XCP discovery.

I had issues with the original one, as I need to pass the connection type (0x00) to the CONNECT command or it will not be accepted. Also I changed how the results as displayed, not a simple True/False but also the error code, because some commands could be supported but they fail if you don't provide the right parameters.

Also I added a filtering to the messages, so normal CAN traffic will not interfere with the discovery.

kasperkarlsson commented 6 months ago

Hi there!

First of all, thank you very much for sending a PR!

Sorry to keep you waiting, but I will review this as soon as I can 😅 Just wanted to let you know that this has not been forgotten.

giudasg commented 5 months ago

Ok. Thanks for you review. When I have the time I will do the changes that you suggested.

kasperkarlsson commented 5 months ago

Ok. Thanks for you review. When I have the time I will do the changes that you suggested.

Sounds great! If you cannot find time and would like assistance in fixing these changes, just let me know 🙂

kasperkarlsson commented 3 months ago

Hi there, just checking in on the status of this PR 🙂 I aim to have a go on fixing the suggested changes from the review and merging shortly (unless you happen to already have them ready, of course!).