search

CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
751 stars 197 forks source link

Add support for service $23 - read memory by address #114

Closed alexdetrano closed 4 months ago

alexdetrano commented 4 months ago

This is basically a rewrite of https://github.com/CaringCaribou/caringcaribou/pull/79 but only focusing on the memory read code. I fixed it up and isolated the changes as discussed in that PR. I've used it extensively against real modules and it works great.

kasperkarlsson commented 4 months ago

This sounds very promising! This is just to let you know that the PR has been noticed, and I aim to review the proposed changes soon 👍

kasperkarlsson commented 4 months ago

FYI: I had a closer look at your suggestion and it turns out there was already a dict for NRC value -> NRC name lookup, which I had forgotten about 😅 Moved over to use this consistently in https://github.com/CaringCaribou/caringcaribou/commit/61f89a5802af586b83d1182b47ac0e6e2c0b8aa8