CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
738 stars 193 forks source link

Add support to write DIDs from command line #118

Open alexdetrano opened 2 months ago

alexdetrano commented 2 months ago

See https://github.com/CaringCaribou/caringcaribou/issues/117. In summary, the testing harness is failing and I need help debugging!

kasperkarlsson commented 2 months ago

Hi there, I just wanted to say that I have had a first look and cleaned up the code a bit (branches where uninitialized variables were called etc), but finding the root cause of the error remains 😅 I will have another look!

kasperkarlsson commented 2 months ago

Update: My current gut feeling says your code is not at fault. It might be caused by a bug in the testing harness, where the MockEcuIso14229 implementation is broken which affects its ability to keep state within the UDS test suite.

Digging into that class and its parents has caused me to make a few double takes so far, I will have to keep looking 😅 Might be threading related.