CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
738 stars 193 forks source link

Python 3 support #31

Closed kasperkarlsson closed 6 years ago

kasperkarlsson commented 6 years ago

All modules should support both Python 2 and Python 3.

The end of life of Python 2 is less than two years away [1]. There is really no need to wait until then to have full Python 3 support. We should of course keep backwards compatibility for Python 2 as well.

[1] https://www.python.org/dev/peps/pep-0373/#maintenance-releases

kasperkarlsson commented 6 years ago

This work has been ongoing since before the issue was created and should be complete now. Verified in both Python 2.7 and 3.6.

Relevant commits: https://github.com/CaringCaribou/caringcaribou/commit/7bd0a185a1b668e625c7597517a2fba7ef33331c https://github.com/CaringCaribou/caringcaribou/commit/f5c71cb2a5453230aa4e7ebb3e277d154adad704 https://github.com/CaringCaribou/caringcaribou/commit/0b1242d1dd33ab664196548ecbdc8781e07ab264 https://github.com/CaringCaribou/caringcaribou/commit/b7178d1d815e76ec082aa0474e11ee1b859e10de https://github.com/CaringCaribou/caringcaribou/commit/e0d3feb185551953cac887c6cfc0bacab0424a90