search

CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
738 stars 193 forks source link

Addresses Issue #52 - Interface Agnostic #53

Closed bhass1 closed 5 years ago

bhass1 commented 5 years ago

Removed -i flag from cc.py and removed references to DEFAULT_INTERFACE.

The Python-Can library supports more than just SocketCAN, and by removing the -i flag, more control is given to python-can and configuration occurs at that layer.

kasperkarlsson commented 5 years ago

While I understand that hard-coding to SocketCAN in the default case could be undesired for some setups, this seems like a quite drastic move.

I do not see why the possibility to specify an interface needs to be removed altogether, simply because the current default value is not a perfect match for everyone. Wouldn't it make better sense to figure out how to best handle the default value instead?

For example - how would this approach work in setups using multiple interfaces, where multiple instances of CC are run in parallel? Currently, this is solved by simply passing the desired interface using the i flag when starting each instance.

kasperkarlsson commented 5 years ago

Closing without merge, as this PR would break setups using multiple interfaces.

We will keep the discussion going in https://github.com/CaringCaribou/caringcaribou/issues/52