CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
738 stars 193 forks source link

dcm subfunc always generates length 3 #65

Closed fearfulspoon closed 3 years ago

fearfulspoon commented 3 years ago

No matter what indices are provided, the function always generates length 3.

See pull request for suggested fix: https://github.com/CaringCaribou/caringcaribou/pull/64

kasperkarlsson commented 3 years ago

PR merged. Thank you very much for your contribution, @fearfulspoon!

Would you like to be listed under the Contributors section at https://github.com/CaringCaribou/caringcaribou#contributors ? If so, just let me know which name/handle to add :slightly_smiling_face:

fearfulspoon commented 3 years ago

I would like that, thank you. FearfulSpoon works.

kasperkarlsson commented 3 years ago

https://github.com/CaringCaribou/caringcaribou/commit/1a017b5a9c01d3ed1dbde7bbbc937e8928bc9b1c

Thanks once again - closing this issue now 👍