Closed tomervipol closed 8 months ago
kasperkarlsson
commented
2 years ago Happy to hear that you are fixing the issues @tomervipol 💪
Just make sure to push the changes to your pull request branch, so they get included here in the PR as well!
tomervipol
commented
2 years ago hi, fixed the little issues. the tests now fail with the pcan mode activated, maybe because they're trying to create a few diffrent bus objects on one physical bus, i'm not sure. and i'll look at adding at a centralized bus creation in can_actions.
tomervipol
commented
2 years ago commit message sums the changes up pretty well
kasperkarlsson
commented
2 years ago All right! I will have a look at these changes shortly, just came back from BlackHat/DEF CON the other day 🙂
tomervipol
commented
2 years ago hey @kasperkarlsson how's it going?
kasperkarlsson
commented
2 years ago Hi @tomervipol - sorry for keeping you waiting, this has taken me way longer time than expected (and also way longer than acceptable). I will try to get this in within the coming days!
P3tray
commented
1 year ago Is this every going to go anywhere?
tomervipol
commented
1 year ago Oh yeah sorry about that. I have been really busy. I don't think i will have time to fix the code as suggested in the near future.
On Mon, 5 Jun 2023 at 9:16 P3tray @.***> wrote:
Is this every going to go anywhere?
— Reply to this email directly, view it on GitHub https://github.com/CaringCaribou/caringcaribou/pull/76#issuecomment-1576110904, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOGZ6SXL6PSK7SDD6S5YL3XJV2TNANCNFSM55N4KGXA . You are receiving this because you were mentioned.Message ID: @.***>
kasperkarlsson
commented
8 months ago Closing PR due to inactivity - feel free to send a new one if you ever have the time to fix the remaining issues :slightly_smiling_face:
P3tray
commented
8 months ago 😔
added support for Pcan on windows, CAN-FD and unlocking using custom key & seed functions. I used this tool for research and testing mainly on xcp on a project, the need arised for zero padding for my target to respond, using PcanBus as the CANbus directly instead of a linux socketcan interface and the automation of unlocking command groups after reversing the seed and key mehcanism. Added flags for: zero padding windows pcan as a bus *CAN-FD support Added XCP_unlock in XCP module, intended use is to write a function in "unlock_functions.py" that generates key from seed and to specify as a cli parameter.