search

CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
751 stars 197 forks source link

Added Dump Memory Feature #79

Open CanBusHack opened 1 year ago

CanBusHack commented 1 year ago

I copied dump_dids and recreated it to support dump memory using the uds.read_memory_by_address method.

I updated the can.Bus() functions to include both "Channel" and "Interface" (optional).

Formatting fixes.

kasperkarlsson commented 1 year ago

Hello @CanBusHack / @LemmonAuto. There seems to be quite a bit of action in this PR with commits still being added - please let me know when it is in a state ready for review, and I will be happy to take a closer look 👍 Please note that a PR should preferably fix/add one bug/issue/feature.

CanBusHack commented 1 year ago

This should only add one feature! But yes there were some bugs that were squashed with it. I'll try to keep it seperate from now on.

I found one more bug that needs to be fixed for the PR. Updating that now.

CanBusHack commented 1 year ago

Looks like I've commited what I can. Please feel free to review.

Cr0wTom commented 1 year ago

Is this still up for review, can we fix it and pull it?

kasperkarlsson commented 1 year ago

I copied dump_dids and recreated it to support dump memory using the uds.read_memory_by_address method.

Adding this feature might very well be useful 👍

I updated the can.Bus() functions to include both "Channel" and "Interface" (optional).

This is a separate feature and should therefore preferably be done as a separate PR. We might already have one on the way, see discussion in https://github.com/CaringCaribou/caringcaribou/issues/84

The PR also has a bunch of conflicts in need of resolving.

CanBusHack commented 1 year ago

Are you looking for me to solve these conflicts? What are they specifically?