Closed breachcircuit closed 1 year ago
Hey, good work, I have this fix as part of this pull request: https://github.com/CaringCaribou/caringcaribou/pull/88 can you check it and if it makes sense put it as one? Thanks
Hi @Cr0wTom,
I've just checked out your pull request and really appreciate the work on the UDS module.
Regarding the CAN Bus implementation fixes, I would see two conflicting arguments closing this PR:
Looking forward to your feedback!
Hi @breachcircuit ,
Yes it makes sense, if this PR get's accepted I will update the code so I will incorporate your changes.