CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
751 stars 197 forks source link

Fix Issue 84: Enhancements in command line interface to match `python-can` naming convention #89

Closed breachcircuit closed 1 year ago

breachcircuit commented 1 year ago
Cr0wTom commented 1 year ago

Hey, good work, I have this fix as part of this pull request: https://github.com/CaringCaribou/caringcaribou/pull/88 can you check it and if it makes sense put it as one? Thanks

breachcircuit commented 1 year ago

Hi @Cr0wTom,

I've just checked out your pull request and really appreciate the work on the UDS module.

Regarding the CAN Bus implementation fixes, I would see two conflicting arguments closing this PR:

  1. I wasn't able to identify the documentation changes in your pull request. Updates to the documentation and troubleshooting guide are crucial in my opinion, as the change in the command line interface has the potential to break a lot of user code upgrading to this version.
  2. Continuing on the potential to break user code implementing this change, I would consider it good practice to keep this in a separate PR, as it might spark some discussion that does not concern the UDS module upgrades.

Looking forward to your feedback!

Cr0wTom commented 1 year ago

Hi @breachcircuit ,

Yes it makes sense, if this PR get's accepted I will update the code so I will incorporate your changes.