search

CaringCaribou / caringcaribou

A friendly car security exploration tool for the CAN bus
GNU General Public License v3.0
751 stars 197 forks source link

fixed dump_dids bug so only the DID value is displayed #96

Closed alexdetrano closed 1 year ago

alexdetrano commented 1 year ago

dump_did output mistakenly contained the response code and the requested DID. This commit removes that information and only displays the DID payload to the user.

kasperkarlsson commented 1 year ago

Hi there and thank you for this PR!

I would just like to see a length check before reading index 3: from the response, as we are only sure it has a length of at least 2 when that line is reached. If you add this I will gladly accept the PR (and if you don't have time to do this, I could of course add it for you - just let me know 😃)

alexdetrano commented 1 year ago

no problem, I added a length check and some comments.

kasperkarlsson commented 1 year ago

Excellent! Thank you very much 🎉