search

CariusLars / ar_flutter_plugin

Flutter Plugin for AR (Augmented Reality) - Supports ARKit on iOS and ARCore on Android devices
MIT License
322 stars 233 forks source link

fix some bugs #89

Closed Koobonik closed 2 years ago

Koobonik commented 2 years ago

Hi guys,

I found some error or some bug

  1. This prevents the app from turning off when other errors occur in addition to errors occurring in the camera. (There's nothing bad about this.)

  2. I think the 'addNode' function should return true only when the node is well placed. Therefore, I wrote the code to return false otherwise.

CariusLars commented 2 years ago

hey @Koobonik I completely missed this one, sorry! Is this still up-to-date? In that case I will merge it 👍

Koobonik commented 2 years ago

Sure! You can merge it now !

CariusLars commented 2 years ago

awesome! Could you write an entry for your fixes into changelog.md (just use v0.6.3) and also set this version number in the, readme and the pubspec.yaml? I can then just merge and publish the fixed version to the flutter store :)

Thanks for your contribution!

Koobonik commented 2 years ago

Hi @CariusLars ! I complete about your request! Thank you for accept my commit :)