Add a new game with the name and description

Carkzis / Ananke

An ongoing project to create a companion app to a board game!

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Add a new game with the name and description #2

Closed Carkzis closed 7 months ago

Carkzis commented 10 months ago

Scenarios:

Using a button on the Game screen, move to the New Game screen.
Add a game name in a text box with a 30 character limit.
Add a description in text box with a 200 character limit.
Press a button to add a game with the provided name and description to a local database, and transport you back to the Game screen.
If no name OR no description is provided, no game will be added to the database and you will get a toast explaining why.
If a game name already exists, no game will be added to the database and you will get a toast explaining why.
Going back will take you to the Game screen.

Carkzis commented 10 months ago

Already added (in #1) are:

Using a button on the Game screen, move to the New Game screen.
Going back will take you to the Game screen.

Can also press a button on the New Game screen to add a game with dummy data, which would transport the user back to the Game screen. This needs updating to use real data provided in the text boxes.

Carkzis commented 10 months ago

Consider adding developer button for adding dummy data to be removed at a later date.

Carkzis commented 9 months ago

Remaining

Functionally: Adding a toast. Visually: Everything in the New Game screen. Refactoring: NewGameScreen composables, and the ViewModel needs hoisting into an undetermined class, allowing the removal of the DummyNewGameViewModel and DummyGameRepository.

Carkzis commented 9 months ago

Toast added, except it is not a Toast, it is a Snackbar.

Functionality bugs:

Cannot empty the title text field, it will enforce 1 character if you have started typing.
If you attempt to enter an invalid title, you will still be redirected to the GameScreen from the NewGameScreen.
Snackbar is hidden by keyboard.

Carkzis commented 9 months ago

Addressed known functionality bugs.

Carkzis commented 8 months ago

To do:

Use Route that will pass values from the ViewModel.
Finish remaining Compose Previews.

Carkzis commented 8 months ago

NewRouteGame now used which holds the view model, NewGameScreen only has state.

Amended NewGameScreen tests to use NewGameRoute so that it can change the state of the NewGameScreen; however, can consider splitting them in future with NewGameScreen tests only focussing on what is on the screen without interacting with it.

Compose Previews updated.

Carkzis commented 8 months ago

Basic new game functionality has been added with just the name and description, these show on the GameScreen in a list once added.

Ticket done.

Carkzis commented 7 months ago

Need to do a missed item:

If a game name already exists, no game will be added to the database and you will get a toast explaining why.

For the time being, will add a random number to the end of the dummy game titles to prevent collisions when adding them.

Carkzis commented 7 months ago

NavigationTest.navigates from new game screen back to game screen when new game added needs fixing, cannot find the "Add New Game" button on New Game screen (but can see the items at the top of the screen!).

Carkzis commented 7 months ago

Fixed NavigationTest.navigates from new game screen back to game screen when new game added by allowing scrolling in Robolectric test.

Added GameAlreadyExistsException and snackbar message for when game name already exists.

Carkzis commented 7 months ago

PR https://github.com/Carkzis/Ananke/pull/4 merged.

Moving to done.