Allowing retry saving output audio when saving failed

CarlGao4 / Demucs-Gui

A GUI for music separation AI demucs

GNU General Public License v3.0

499 stars 37 forks source link

Allowing retry saving output audio when saving failed #60

Open CarlGao4 opened 3 months ago

CarlGao4 commented 3 months ago

If an output write failed, the whole separation would be performed again, which is very time-consuming. Add an option to pause the separation process immediately when writing fails so user can change writing parameters and try saving again and again.

charliemarshall1996 commented 3 months ago

Hello,

I think I'll give this a go, if that's ok? Is there a contribution doc on the repo - just want to keep within standards!

CarlGao4 commented 3 months ago

That's great news that you'd like to contribute! Actually, I didn't create a contribution doc - just run the black formatter before committing (with argument -l 120) Sorry for making the codes such a mess as I made so few comments...

CarlGao4 commented 3 months ago

@charliemarshall1996 Are you still working on this?

charliemarshall1996 commented 3 months ago

Hi!

Apologies, just been made redundant so my attention is elsewhere. If need be, please pass this off to someone else.

On Mon, 20 May 2024 at 14:38, Weiqi Gao @.***> wrote:

@charliemarshall1996 https://github.com/charliemarshall1996 Are you still working on this?

— Reply to this email directly, view it on GitHub https://github.com/CarlGao4/Demucs-Gui/issues/60#issuecomment-2120481603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZOUAKDYMSH2UQISF6AK4NTZDH4EFAVCNFSM6AAAAABHP2LT6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGQ4DCNRQGM . You are receiving this because you were mentioned.Message ID: @.***>

CarlGao4 commented 3 months ago

Never mind, I'll do it myself