search

CarletonURocketry / ground-station

The ground station software used to interface with the ground station LoRa board and distribute signals from the rocket across websocket connections.
https://carletonurocketry.github.io/ground-station/
MIT License
7 stars 6 forks source link

Fix telem parser #55

Closed linguini1 closed 10 months ago

linguini1 commented 10 months ago

Pyright fixes!

This branch configures Pyright to ignore telem-parser.py. It is legacy code from our old system, and we will likely never use the SD card encoding for recording flight data again, so I have no motivation to actually re-write and test it to resolve all the errors and make it better.

Quite honestly, it's a shitshow and ignoring it is the best option.

I have also resolved the issues in the other two files that were causing Pyright to fail.

Lastly, virtual environments in the project root by the name of venv (as is the convention) will now be ignore by Pyright. This means that local checks executed by running pyright . will not check type errors in the virtual environment code, only project source files. This is significantly faster and also only shows relevant diagnostics.

Flake8 issues

Turns out that there was a bug in Flake8 for Python 3.12 where it would require spaces after punctuation like , or :, even in strings. Upgrading to flake8 6.1.0 solves this issue, so that's what I've put in the requirements.txt file. Workflows should pass now.