search

CarletonURocketry / ground-station

The ground station software used to interface with the ground station LoRa board and distribute signals from the rocket across websocket connections.
https://carletonurocketry.github.io/ground-station/
MIT License
7 stars 6 forks source link

test parse_radio_block done #82

Closed Juan-789 closed 7 months ago

Juan-789 commented 8 months ago

^^^

EliasJRH commented 8 months ago

this pr should make the checking of the block contents easier once implemented. Until then can you also add some tests to ensure that we catch errors correctly?

Juan-789 commented 8 months ago

Surely

EliasJRH commented 8 months ago

I'm not sure what this is testing that isn't covered by test_block_data and test_block_header in the tests/parsing/ directory. Was there something those test cases don't cover that you were hoping to implement? Could that test be added to one of the other test files?

I wanted to test that the parse_radio_block function works correctly when applied generally to the received information, whereas test_block_data tests for specific block types.

linguini1 commented 8 months ago

I'm not sure what this is testing that isn't covered by test_block_data and test_block_header in the tests/parsing/ directory. Was there something those test cases don't cover that you were hoping to implement? Could that test be added to one of the other test files?

I wanted to test that the parse_radio_block function works correctly when applied generally to the received information, whereas test_block_data tests for specific block types.

Gotcha, makes sense!

linguini1 commented 8 months ago

This PR conflicts with main so make sure you merge main and re-request a review.

Juan-789 commented 8 months ago

nvm it broke