search

CarletonURocketry / ground-station

The ground station software used to interface with the ground station LoRa board and distribute signals from the rocket across websocket connections.
https://carletonurocketry.github.io/ground-station/
MIT License
7 stars 6 forks source link

[BUG] telementry_utils.py and parse_radio_block function. #84

Closed Juan-789 closed 6 months ago

Juan-789 commented 6 months ago

When inputting a block header with a block subtype that its recognized by DataBlockSubtype yet not implemented, e.g. image

It should raise NotImplementedError image yet it raises at v1/data_block.DataBlock.parse the DataBlockUnknownException image

when it should go to the parse_data_block image

Juan-789 commented 6 months ago

With further investigation found out maybe I need to create DataBlocks for the remaining block subtypes or could do a work around just to raise the proper NotImplemented Error @linguini1

linguini1 commented 6 months ago

With further investigation found out maybe I need to create DataBlocks for the remaining block subtypes or could do a work around just to raise the proper NotImplemented Error @linguini1

Tbh just toss the raise DataBlockUnknownException and replace with NotImplemented. See my comment on PR #89.