search

CarletonURocketry / ground-station

The ground station software used to interface with the ground station LoRa board and distribute signals from the rocket across websocket connections.
https://carletonurocketry.github.io/ground-station/
MIT License
7 stars 6 forks source link

Packet header fields #86

Closed linguini1 closed 6 months ago

linguini1 commented 6 months ago

In modules/telemetry/v1/block.py, the version and src_addr fields in PacketHeader should be constructed using the enums for packet versions and device addresses.

This will validate fields instead of having plain integers which could contain erroneous values (1000 for source address).

As always, tests may need to be updated to reflect this changes.

EliasJRH commented 6 months ago

Packet header field versions will be checked against the range of valid versions in this pr. We also don't currently use src_addr anywhere, should it even be kept?

linguini1 commented 6 months ago

Packet header field versions will be checked against the range of valid versions in this pr. We also don't currently use src_addr anywhere, should it even be kept?

Source address must be kept since it is a packet field.