search

CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
223 stars 45 forks source link

Allow for additonal features in GNNGraph #210

Closed Dsantra92 closed 1 year ago

Dsantra92 commented 2 years ago

There are cases where the shape of the feature array might not have the last dim = number of nodes and edges. For example: In a mesh represented by a graph where the vertices are nodes. Currently, there is no way to include triangular faces, except for graph data (which they are not).

GNNGraph should be allowed to contain such features which are not either node or edge. cc: @CarloLucibello

CarloLucibello commented 2 years ago

How does PyG works in this setting?

Dsantra92 commented 2 years ago

PyG doesn't force checks on features.

CarloLucibello commented 2 years ago

Why we can't store them as graph data?

Dsantra92 commented 2 years ago

We can do it given our current implementation. But at the end of the day, they are not exactly graph level features.

CarloLucibello commented 1 year ago

closing as it not clear how to act on this