Closed 5hv5hvnk closed 1 year ago
Is there a contributing guideline doc so I can fix the build tests at least?
test failures is probably related to some changes in dependencies like FiniteDifferences.jl, I'll have to investigate
I think it would be good to add an example to the example folder showing the full pipeline, since there are some ingredients in the graphormer pipeline which are not part of the layer (e.g. the edge encodings) https://proceedings.neurips.cc/paper/2021/file/f1c1592588411002af340cbaedd6fc33-Paper.pdf
Anyways, this looks very good already
Merging #265 (53efa7d) into master (c5bd656) will decrease coverage by
1.43%
. The diff coverage is13.51%
.:exclamation: Current head 53efa7d differs from pull request most recent head 6aa987d. Consider uploading reports for the commit 6aa987d to get more accurate results
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 81.70% 80.28% -1.43%
==========================================
Files 17 17
Lines 1864 1902 +38
==========================================
+ Hits 1523 1527 +4
- Misses 341 375 +34
Impacted Files | Coverage Δ | |
---|---|---|
src/layers/conv.jl | 74.65% <13.51%> (-4.83%) |
:arrow_down: |
... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@CarloLucibello where should I add the tests ? Secondly is adding tests here similar too PyTest
?
take a look at the test folder. The entry point is test/runtests.jl
. All julia packages are similarly structured.
The organization of the test files reflects the organization of the src files.
Hi @CarloLucibello due to some conflicts that I was trying to resolve the PR is closed now. Let me try fix it and raise another PR
Sure, sorry for that, I made some pretty extensive changes
No problem you can have a look on #275
fixes #251 To do:
@CarloLucibello is there anything else to work on?