search

CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
210 stars 47 forks source link

Support Metal #344

Open CarloLucibello opened 9 months ago

CarloLucibello commented 9 months ago

Needs gather/scatter kernels in NNlib

Dsantra92 commented 9 months ago

Is there a metal support planned for NNlib?

CarloLucibello commented 9 months ago

It could be the case that gather/scatter already work on metal arrays thanks to https://github.com/FluxML/NNlib.jl/pull/487, but it has not been tested yet. Do you have access to some apple silicon?

Or we can add some metal tests on NNlib and execute them on buildkite (e.g. Flux.jl is already testing metal support (https://github.com/FluxML/Flux.jl/blob/master/.buildkite/pipeline.yml)

Dsantra92 commented 9 months ago

I have access to a base variant of apple silicon. I would be happy to test some of these out.

CarloLucibello commented 9 months ago

See https://github.com/FluxML/NNlib.jl/issues/534

achiverram28 commented 3 months ago

I am having the macbook pro m2 pro . I would like to test the metal support with this

achiverram28 commented 3 months ago

Checked out , gather works , but scatter fails due to ERROR: Compilation to native code failed Yes , this is also pointed out in https://github.com/FluxML/NNlib.jl/issues/534