CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
209 stars 47 forks source link

Add heterogeneous add_self_loop support #345

Closed AarSeBail closed 6 months ago

AarSeBail commented 9 months ago

Here is the PR as discussed in #329.

AarSeBail commented 9 months ago

Regarding the method get_edge_weight_nullable, if it keeps popping up in heterogeneous graphs, it may be worth refining.

AarSeBail commented 6 months ago

I believe this to now be initializing edge arrays with the correct type, but please check to confirm. I also extended the test cases marginally.

Tests should pass on latest, but not on nightly, similarly to #356.

CarloLucibello commented 6 months ago

nice, thanks!