search

CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
220 stars 46 forks source link

feat: Add GCNConv support for HeteroGraphConv #367

Closed askorupka closed 6 months ago

askorupka commented 8 months ago

This PR adds GCNConv support for HeteroGraphConv. This is related to issue https://github.com/CarloLucibello/GraphNeuralNetworks.jl/issues/311.

askorupka commented 8 months ago

Done but waiting for https://github.com/CarloLucibello/GraphNeuralNetworks.jl/pull/373 first to simplify things.

askorupka commented 6 months ago

@CarloLucibello ready for re-review. code is programatically working and passing tests. need mathematical check from your side.

needed to introduce conditional behavior in order for both tests to pass (one for GCNConv regular, one for GCNConv for GNNHeteroGraph)