Closed askorupka closed 4 months ago
@CarloLucibello ready for re-review. Needed to remove test as this required putting SimpleWeightedGraphs as a dependency, which is contradictory to the point of moving them to the extension.
Needed to remove test as this required putting SimpleWeightedGraphs as a dependency, which is contradictory to the point of moving them to the extension.
SimpleWeightedGraphs can be a test dependency, you have to put it under [extras] in the Project.toml.
The test can live in test/ext/GraphNeuralNetworksSimpleWeightedGraphsExt/GraphNeuralNetworksSimpleWeightedGraphsExt.jl
@CarloLucibello may I ask for help what else is required to get rid of the error message as below during tests: update: I think I got it
Error: Error during loading of extension GraphNeuralNetworksSimpleWeightedGraphsExt of GraphNeuralNetworks, use `Base.retry_load_extensions()` to retry.
│ exception =
│ 1-element ExceptionStack:
│ ArgumentError: Package GraphNeuralNetworksSimpleWeightedGraphsExt [df50fc6b-8916-5c00-b5b6-a97a04cc2331] is required but does not seem to be installed:
│ - Run `Pkg.instantiate()` to install all recorded dependencies.
This PR add support for weights when generating from SimpleWeightedGraph. This fixes #85.