search

CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
209 stars 47 forks source link

extended GatedGraphConv and NNConv to use AbstactGNNGraph #375

Open Ghaithq opened 4 months ago

Ghaithq commented 4 months ago

This is an attempt in solving #311 partially by extending both NNConv and GatedGraphConv.

Ghaithq commented 4 months ago

Hi @CarloLucibello. Is this correct or did I misunderstand something?

CarloLucibello commented 4 months ago

Thanks for this contribution! It would be nice to have some tests

Ghaithq commented 4 months ago

Should I modify the already made tests for both NNConv and GatedGraphConv to use AbstactGNNGraph. or should I implement new tests. And I was planning on resolving the whole issue should I continue in the same manner?

CarloLucibello commented 4 months ago

Should I modify the already made tests for both NNConv and GatedGraphConv to use AbstactGNNGraph. or should I implement new tests. And I was planning on resolving the whole issue should I continue in the same manner?

you can add tests here https://github.com/CarloLucibello/GraphNeuralNetworks.jl/blob/master/test/layers/heteroconv.jl