search

CarloLucibello / GraphNeuralNetworks.jl

Graph Neural Networks in Julia
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/
MIT License
210 stars 47 forks source link

feat: Add SGConv support for HeteroGraphConv #399

Closed askorupka closed 4 months ago

askorupka commented 4 months ago

This PR adds SGConv support for HeteroGraphConv. This is related to issue https://github.com/CarloLucibello/GraphNeuralNetworks.jl/issues/311.

rbSparky commented 4 months ago

PR #383 also works on sgconv

CarloLucibello commented 4 months ago

this is already being taken care of

askorupka commented 4 months ago

Sorry but I don't support decision regarding closing working PR. The other PR was a draft with comments and unfinished work (not the best practice to block others' work - I'd advise not opening a PR against the upstream for until it's ready), while my PR was working and passing tests. Now I see my code implemented in the other PR without my commits/contribution. One could at least rebase against my branch. FYI @CarloLucibello @rbSparky

CarloLucibello commented 4 months ago

As you can see from the discussion in #383 and from the merged commit https://github.com/CarloLucibello/GraphNeuralNetworks.jl/commit/64b3cbb6f9e80287043ff573fd8a4a87219cc0dc you have been properly credited.