CarlosDerSeher / snapclient

snapclient on ESP32
GNU General Public License v3.0
118 stars 15 forks source link

Volume quiet on LyraT 4.3 #101

Open jonzobot opened 1 month ago

jonzobot commented 1 month ago

Hi Carlos,

As requested under issue #68, that commit appears to have created a small problem relating to volume on LyraT 4.3. Specifically the volume levels have been reduced substantially. It may be that the fix and config changes for that issue may need to be limited to the board in question, i.e. AI Thinker. It is probably not an issue if one is using an external amplifier, but I am using the on-board amp.

hjri commented 3 weeks ago

I had to uncomment https://github.com/CarlosDerSeher/snapclient/blob/master/components/audio_hal/driver/es8388/es8388.c#L462-L468 this section to restore audio volume on my Muse Luxe

Disregard that, i gaslit myself again

More real fix is to add reg -= 0x0c after https://github.com/CarlosDerSeher/snapclient/blob/master/components/audio_hal/driver/es8388/es8388.c#L442

and change 0x1E to 0x21 here:

https://github.com/CarlosDerSeher/snapclient/blob/master/components/audio_hal/driver/es8388/es8388.c#L339-L344