search

CarlosDerSeher / snapclient

snapclient on ESP32
GNU General Public License v3.0
139 stars 18 forks source link

Snapserver autodiscovery fails in ipv6 network #104

Open anabolyc opened 2 months ago

anabolyc commented 2 months ago

Hey @CarlosDerSeher , just letting you know that I found this bug and seems to fix it already.

When autodiscovery found my snapserver on the network, the first discovered address was ipv6, however code has a hardcoded v4 type, therefore address was converted to invalid ipv4 address leading auto discovery to fail.

Here is the fix, you may have a look and let me know if that sounds right to you.

CarlosDerSeher commented 2 months ago

I am just on the phone so can't dive in deep with the code but it seems right to me. If you tested it for ipv4 and 6 and it works it should be ok I guess.