search

CarlosDerSeher / snapclient

snapclient on ESP32
GNU General Public License v3.0
136 stars 18 forks source link

Fix not being able to unmute #98

Open Ebbe opened 3 months ago

Ebbe commented 3 months ago

I'm testing on a Lyrat mini v1.2. If I run master branch, when ever I start the board (or change track) the code goes through a "mute session", but unmute does not work. Sound only comes after changing the volume. With this change it works, at least on my board :)

Ebbe commented 3 months ago

I just might have heard a loud "crack" before starting a track. Perhaps a better solution would be to save the volume and reset that when unmuting?

CarlosDerSeher commented 3 months ago

@derpicknicker this remembers me of something you encountered?

CarlosDerSeher commented 3 months ago

Perhaps a better solution would be to save the volume and reset that when unmuting?

Definitely. Save it within the driver

DerPicknicker commented 3 months ago

@CarlosDerSeher .. yea definitely. This behaviour is only the case for the lyrat mini board .. glad to see that @Ebbe found a solution

DerPicknicker commented 3 months ago

Please share also the sdkconfig. The webinstaller is not working for this board.

DerPicknicker commented 2 months ago

@Ebbe ... How is the Status? Could you add the sdkconfig to your pr? Because the old one doesn't work anymore for the mini.