search

CarlosFdez / pf2e-persistent-damage

Keeps track of persistent damage on actors for PF2E for Foundry VTT
5 stars 4 forks source link

"Persistent damage" not localized in chat #24

Closed Eikwerno closed 2 years ago

Eikwerno commented 2 years ago

Hello! Is there a way to add translation to the module? If so, how could that be provided? Or to pull the existing translations from the core module? unknown

manfred7168 commented 2 years ago

Hi I want to give some explanations on this issue. In the german translation of PF2e I set translation of those persistent damages like this: The bomb deal additional [[/r {1}[persistent,fire]]]{1 Point} @Compendium[pf2e.conditionitems.lDVqvLKA6eF3Df60]{Persistent Fire Damage}. (I entered english texts for your understanding, of course). When showing in descriptions this works as expected [* 1 Point] [Persistent Fire Damage]. But when we activate your persistent damage module it breaks showing the above and no localization. Just by inserting a localization of the Roll-Button within {} I hope this helps analysing.

CarlosFdez commented 2 years ago

Ah sorry I just saw this. That's hardcoded, but it should be localized. It won't be a perfect localization (no handling of RTL languages), but it'll be better than before.

CarlosFdez commented 2 years ago

Done. Persistent Damage for the effect name should now use the condition name defined in the system, which should be PF2E.condition.persistent-damage.name. Let me know if this resolves the issue. I can't really get german working on my foundry for some reason. The sheets are all broken.

Eikwerno commented 2 years ago

Works like a charm as far as I can see. Thank you for the swift action! Much appreciated!