CarlosFdez / pf2e-persistent-damage

Keeps track of persistent damage on actors for PF2E for Foundry VTT
5 stars 4 forks source link

Don't auto remove condition #6

Open JamzTheMan opened 3 years ago

JamzTheMan commented 3 years ago

Could there be an option to not automatically remove a condition? Perhaps it displays a confirmation dialog instead (or not?)

There could be an ability/reaction that negates the check or mods the dc?

CarlosFdez commented 3 years ago

So there's actually a setting to disable the auto remove, however now I'm curious, what would those abilities/reactions be?

DC can be modded when the effect is applied, but a reaction modding the DC is something I haven't heard of. Handling those scenarios even when automation is enabled would be very useful.

The new update does have a setting that effects the auto recover functionality though, for players by default its now an additional button press.

JamzTheMan commented 3 years ago

I can't think of one off hand. But I have a fletchling that has abilities that can add to the DC to flat checks for concealment against him and reduce the DC when targeting concealed.

It wouldn't be out of the realm for an ability to have such a reaction in the future if there isn't already.

An alternate approach would be to "expire" the effect and ignore any expired effects. Then you can manually remove them or more easily re-enable it. (Actually, i'd love the core to do this for all effects, maybe this could be a proof of concept?)

CarlosFdez commented 3 years ago

Will need to keep expiring in mind. I know events can expire, but I would need to think of a way to re-enable it. Also the token and effects panel would still render them, even though a nice grayscale filter would definitely help with readability.