search

CarlosNZ / json-edit-react

React component for editing/viewing JSON/object data
https://carlosnz.github.io/json-edit-react/
MIT License
171 stars 16 forks source link

Missing default-branch in exports in package.json #127

Open dobretzberger opened 3 weeks ago

dobretzberger commented 3 weeks ago

Describe the bug In Version 1.16, the export-clause was introduced in the package.json using conditional exports for import, require and types. That leads to the problem that the library cannot be used in other enviroments, because the default-case is missing. In our case the import using shadow-cljs failes.

Node.js also recommends to add a default if possible, see https://nodejs.org/api/packages.html#conditional-exports

Expected behavior json-edit-react should provide a default case in exports

CarlosNZ commented 3 weeks ago

Okay, thanks for the heads-up, I'll fix this next week (unless someone else wants to make a PR)

CarlosNZ commented 2 weeks ago

Hi @dobretzberger -- I've updated this in v1.17.1. Can you confirm it's working okay for you?