CarlosOrozco88 / ui5-tools

UI5 Tools for vscode
Apache License 2.0
16 stars 2 forks source link

mountPath and BasicAuth for Proxy #1

Closed itelSchiller closed 4 years ago

itelSchiller commented 4 years ago

Hi,

Your tool is really cool! It would make the work of some of our developers easier. But there is still one part missing for efficient work.

For OData BasicAuth and MountPath would be helpful. Mounthpath is very often needed to simulate a "destionation" https://www.npmjs.com/package/ui5-middleware-proxy-basicauth https://www.npmjs.com/package/ui5-middleware-simpleproxy

CarlosOrozco88 commented 4 years ago
CarlosOrozco88 commented 4 years ago

I published a new version with mountpath configurable, it works with odataProxy "Other" configuration.

You can change it in the workspace configuration or with command ui5-tools.configurator.odataProvider

itelSchiller commented 4 years ago

I have tested it with the north wind service, but it does not seem to work. image image

CarlosOrozco88 commented 4 years ago

Hi,

could you try now with version 0.1.8? Additionally, when Other odataProxy is configured, odataUri and odataMountPath accepts multiple entries:

Configuration: image

Using first proxy: image

Using second proxy: image

You can check it with the example workspace included in this repo.

Thanks for de feedback!

itelSchiller commented 4 years ago

Great, now it works! That would help a lot of people in the development.

Only in a special case does it get complicated. If mine calls up a server/gateway with a port in the URL https://my.internal.Server:com:8443/

Then the following error appears: GET http://localhost:3000/mydestination 500 (Internal Server Error) Error occured while trying to proxy to: localhost:3000

CarlosOrozco88 commented 4 years ago

I dont know how to check this error, i use this config in work that use ports in the url: image Your url https://my.internal.Server:com:8443/ contains two :, i dont know if this could be the problem... That config "is the same" that this one: image

By the way, if you think its necessary, i can concatenate the odataMountPath with odataUri in order to avoid this configuration, so it will look like in the future: image I dont like this, because then you cant customice odataMountPath with "random" string and forces to exist that path in odataUri server)

Also i think its necessary another config property to separate resourcesUri and odataUri, and Other option to resourcesProxy that allows to customice resourcesUri

itelSchiller commented 4 years ago

The : behind com was accidental.

Probably that are my own network problems. Because I call it up over VPN. I can access Gateway's OData service directly from the browser, but not the proxy.

CarlosOrozco88 commented 4 years ago

Im calling it up over VPN too. I think i will activate logLevel of this proxy to debug and other proxys to error debugLevel (next version), then in vscode menu: Help > Toggle Developer Tools > Console so you can check the logs, i hope we can find some helpfull messages...

By the way, you can check it now but all proxy are in info debugLevel.

CarlosOrozco88 commented 4 years ago

Now you can create a .env file in root workspace with: UI5TOOLS_ODATA_USER=user1 UI5TOOLS_ODATA_PASSWORD=pass1 If you have multiple destinations, then the next ones: UI5TOOLS_ODATA_USER_2=user2 UI5TOOLS_ODATA_PASSWORD_2=pass2 UI5TOOLS_ODATA_USER_3=user3 UI5TOOLS_ODATA_PASSWORD_3=pass3 ... Can you have a look, please?

Thanks!

itelSchiller commented 4 years ago

that works with authentication. also with the mutiple mountpath/destionation

thanks with the dev tools tip

My own mistake is that the gateway has a self-signed certificate. Either you would have to install the certificate on your device, or you could disable this SSL check, like in Postman or in the ui5-tooling-middleware (see screenshots)

Bildschirmfoto 2020-06-09 um 08 40 21

image

CarlosOrozco88 commented 4 years ago

Hi!

In 0.3.1 ssl check is disabled by default. I hope this solves the problem...