search

CarlosOrozco88 / ui5-tools

UI5 Tools for vscode
Apache License 2.0
16 stars 2 forks source link

Asking to clear or remove the dist folder? #11

Closed jayakrishnanc2013 closed 3 years ago

jayakrishnanc2013 commented 3 years ago

Hi, I was using this extension in my development inside the vs code. It was working great made my job very easy to build and deploy. But after a week gap today i tried to do the build , that time i got an popup to delete or clear the dist folder. Sometime back i was getting the n.export not a function issue but later when i try to do the build or deploy i am getting this popup.

CarlosOrozco88 commented 3 years ago

Hi!

Are you using a windows system? I am using a mac and i do not have this issue.

I will check it later.

Thanks for the report

jayakrishnanc2013 commented 3 years ago

Hi Carlos, yes i am using windows

CarlosOrozco88 commented 3 years ago

Can you build the project? I mean, the problem is in both options (deploy/build) or only in deploy? image

jayakrishnanc2013 commented 3 years ago

Yes in both cases.

jayakrishnanc2013 commented 3 years ago

Hi Carlos, Thanks for your email. In both cases it occurs. Getting a popup to remove/clear the dist folder. I

When i do build, i removed the dist folder and again run the build command it is working.

However when indo the deploy option i again it is asking me to remove the dist folder.

Thanks.

On Wed, 28 Jul 2021 at 06:38, Carlos @.***> wrote:

Can you build the project? I mean, the problem is in both options (deploy/build) or only in deploy? [image: image] https://user-images.githubusercontent.com/11719827/127247181-c9feb5fd-4ad9-43ba-96c0-eba4cf973bb1.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CarlosOrozco88/ui5-tools/issues/11#issuecomment-887934126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZEG4NDPWXK4QGTEYSJ3CDTZ5KBHANCNFSM5BCTRDYA .

-- Thank you, Regards, JK.

CarlosOrozco88 commented 3 years ago

Hi,

it seems it is a chokidar/windows issue. I just published ui5-tools 1.0.3 with a few changes to workaround the problems in dist folder.

Wish it works

Thanks!

jayakrishnanc2013 commented 3 years ago

Hi Carlos, Yes now i am able to build and deploy it to the SAP System. As you mentioned it is a workaround , will it be a complete solution or how? Could you please give some info on this. Thnaks, JK.

CarlosOrozco88 commented 3 years ago

The main problem is detecting ui5 projects. I mean, in case of not using multiroot workspaces, it is necessary to search for every manifest and parse it (im checking it has sap.app.id property). In order to do the same logic in every workspaces, i do this search allways.

The extension has a function that do this search at startup. But you can add, remove or update manifests files so the extension has to listen for changes in manifests files in order to execute the search function again (other files like .env file - to restart the server - and each project file - to restart browser -).

Thats why i am using chokidar. In 0.6.X chokidar was used only for browser refresh, and manifest files are watched with vscode api. The main problem is that it cant detect file changes outside the ide, like copy paste files or similar and i cannot trust the projects are allways detected correctly, so in every server start i was doing a project search that it is not needed now.

Conclusion: i will check for a real solution with chokidar. If there are not one, i will look for another dependency or change the extension do manifest discovery.

Hope this explains the problem

Thanks!

jayakrishnanc2013 commented 3 years ago

Thanks Carlos for the explanation 👍🏼