search

CarlosZ96 / Carlos-Portfolio

MIT License
2 stars 0 forks source link

Activity day 5 #6

Open CarlosZ96 opened 1 year ago

CarlosZ96 commented 1 year ago

Hello, this is my desktop version. Any suggestion is welcome.

JuanDBta commented 1 year ago

Hey Carlos, great work! It looks like you have put enormous effort into this project...but If you leave me, I would like to suggest you that if you organize better your HTML file, it would be easier for you to work in the next assignments. Good luck with your submission, I hope they approved it fast!

sergio-usma commented 1 year ago

mr-bean-thumbs-up

Hi Carlos, you have made a reasonable effort in your project. However, I would suggest that you organize better the CSS code. You can use an order like, for example:

  1. Positioning
  2. Box Model
  3. Typography and fonts
  4. Visual effects
  5. Miscellaneous

And for the class naming, you can use, for example, the BEM methodology https://en.bem.info/methodology/css/ to ease the process of coding review and keep it more organized. So, this is an optional fix, but it could be very useful for your future projects.

sanamrahimi commented 1 year ago

Good Job. 👍

CarlosZ96 commented 1 year ago

Thank you very much for your advice, I will take it into account.