CarmineOptions / derisk-research

MIT License
4 stars 14 forks source link

Add notebook to analyze looping #105

Closed danielcdz closed 1 month ago

danielcdz commented 1 month ago

Summary

Visualizations

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

lukaspetrasek commented 1 month ago

@danielcdz At first glance, the code looks really nice! I still don't think it's possible that no user has completed the loop, so I started debugging that part, but I have yet to finish (hopefully tomorrow).

In the meantime, pls check the comments above. And pls remove duplicate pieces of code that are used more than once, including function definitions 🙏🏼

danielcdz commented 1 month ago

@danielcdz At first glance, the code looks really nice! I still don't think it's possible that no user has completed the loop, so I started debugging that part, but I have yet to finish (hopefully tomorrow).

In the meantime, pls check the comments above. And pls remove duplicate pieces of code that are used more than once, including function definitions 🙏🏼

Related to that is not visible in the charts but I got a number for a total of user that made all the loop I will attach that when I address your comments 🫱🏻‍🫲🏼

lukaspetrasek commented 1 month ago

@danielcdz At first glance, the code looks really nice! I still don't think it's possible that no user has completed the loop, so I started debugging that part, but I have yet to finish (hopefully tomorrow). In the meantime, pls check the comments above. And pls remove duplicate pieces of code that are used more than once, including function definitions 🙏🏼

Related to that is not visible in the charts but I got a number for a total of user that made all the loop I will attach that when I address your comments 🫱🏻‍🫲🏼

Cool, thanks!

danielcdz commented 1 month ago

Visualization for looping users:

image

lukaspetrasek commented 1 month ago

Visualization for looping users:

image

Nice visualizations in general, but I still think that there's something wrong with the loop computations.

danielcdz commented 1 month ago

Looping users:

image