ODHack: Make it easier to sum 2 Portfolio instances

[lukaspetrasek]

Adjust the Portfolio class so that two of its instances can be summed together, resulting in a portfolio containing tokens from both summed portfolios. The Portfolio class is implemented here: https://github.com/CarmineOptions/derisk-research/blob/master/src/helpers.py#L78.

[lindsaymoralesb]

Hi! @lukaspetrasek I would like to take this task. I estimate no more than a day for the changes to be ready. This would be my first issue on this project, but I have experience working with python. The proposed approach would be to implement a custom add method in the class, which will create a new instance of Portfolio with he combined tokens.

[lukaspetrasek]

Hi, assigning @lindsaymoralesb , because they provided a better description of the approach and lower ETA.

@lindsaymoralesb Let me know if everything is clear and whether you'll be working on the issue. If you have any questions, please ask here. What is you TG handler please? 🙏🏼

Consider joining our TG group. See also our contributor guidelines.

[lindsaymoralesb]

Thanks! Yes, I’ll be working on this. Already joined the group, my tg is @lindsaymorales. Will let you know if I have any doubts.

[lindsaymoralesb]

hey @lukaspetrasek ! so the changes are already in this PR.

[lukaspetrasek]

Hi, added 1 comment 😉

[Josh-121]

will be willing to work on this issue, very experienced with python and can deliver in few hours from assignment.

[lukaspetrasek]

Hi @lindsaymoralesb , few more simple comments.

[lindsaymoralesb]

Hey! @lukaspetrasek did you leave them on the PR? I can’t find them

[lukaspetrasek]

Hey! @lukaspetrasek did you leave them on the PR? I can’t find them

Oh shoot, forgot to submit them. Now it's done.

[lindsaymoralesb]

No worries! Changes are ready for review.