CarmineOptions / derisk-research

MIT License
4 stars 14 forks source link

ODHack: Fetch parameters for zkLend dynamically in `data_handler` #115

Closed lukaspetrasek closed 1 month ago

lukaspetrasek commented 1 month ago

Fetch zkLend's token parameters dynamically.

Steps: 1) Check out the static settings for the zkLend lending protocol: https://github.com/CarmineOptions/derisk-research/blob/master/data_handler/handlers/loan_states/zklend/settings.py#L23. 2) Currently, the token parameters are static, but in reality, they change once in a while. Adjust the code so that we're able to fetch the current/latest parameters dynamically from chain. 3) Adjust all references of the original static settings, so that the static settings are no longer needed.

EmmanuelAR commented 1 month ago

Hey can i work on this? I can start today and could finish on one week ago or less, i already work on python, in Giza project

lukaspetrasek commented 1 month ago

Okay, assigning you @EmmanuelAR . But note that the OD Hackaton tasks should be finished by the end of the week 🙏🏼

@EmmanuelAR Let me know if everything is clear and whether you'll be working on the issue. If you have any questions, please ask here. What is you TG handler please? 🙏🏼

Consider joining our TG group. See also our contributor guidelines.

EmmanuelAR commented 1 month ago

Excellent I will stray today and let u know if I have a question @lukaspetrasek

EmmanuelAR commented 1 month ago

Hello team, yesterday @lukaspetrasek asssigme this issue to me, thanks for that.

As soon that i read the issue i uderstand to make a method to fetch ZKLEND_SPECIFIC_TOKEN_SETTINGS info and not mantain it static.

Captura de pantalla 2024-05-29 a la(s) 10 03 58 a  m

Did someone knows where did a can make that call on chain to have that info? If theres an example of how to make that call?

lukaspetrasek commented 1 month ago

Answered on TG.

Josh-121 commented 1 month ago

willing to work on this issue, I have an understanding to write a call to fetch the required data and replace the static ones. Will be done in few hours

lukaspetrasek commented 1 month ago

willing to work on this issue, I have an understanding to write a call to fetch the required data and replace the static ones. Will be done in few hours

Hi, thanks, but @EmmanuelAR is nearly done.

EmmanuelAR commented 1 month ago

Pr: #121

lukaspetrasek commented 1 month ago

Pr: #121

Thanks, I'll take a look over the weekend.