Add / Remove liquidity from Nostra Pools

CarmineOptions / konoha

A toolkit for DAO-like governance on Starknet

Apache License 2.0

30 stars 41 forks source link

Add / Remove liquidity from Nostra Pools #102

Closed saimeunt closed 5 months ago

saimeunt commented 5 months ago

This PR introduces the possibility for the treasury to deposit/withdraw liquidity on Nostra Pools. The feature has been tested but lacks 100% coverage at the moment.

Still needs some polishing (more tests, events, etc.), will finish it ASAP.

tensojka commented 5 months ago

The issue was regarding Nostra Lend Pools, not Nostra Swap LP Pools. This is why I asked all contributors to create a draft PR – precisely so that this doesn't happen.

tensojka commented 5 months ago

As this was not an ODHack task, this cannot be eligible for ODHack.

It also makes no sense to have amount_0_min and amount_1_min fixed as input argument to the function – prices move and it takes a week to pass a proposal. More reasonable would be to calculate the amount_min with oracle data and use that.