Braavos wallet write returns an error for successful executions

CarmineOptions / konoha

A toolkit for DAO-like governance on Starknet

Apache License 2.0

30 stars 41 forks source link

Braavos wallet write returns an error for successful executions #70

Open tomashobza opened 6 months ago

tomashobza commented 6 months ago

in files frontend/src/components/NewProposalForm.tsx & frontend/src/components/Proposal.tsx
Braavos wallet connection only works on HTTPS or localhost
transaction goes through but an error is returned by the SDK

tensojka commented 6 months ago

@DaveVodrazka I assume you faced this issue already, not really a blocker since the tx still goes through, but curious to know what's wrong

DaveVodrazka commented 6 months ago

I don't use starknet-react on the Carmine app, so I don't have much experience with it 🤷‍♂️ But if I have the time I will check what's going on (but probably not anytime soon)

Jemiiah commented 2 months ago

I would love to work on this Issue @tensojka

tensojka commented 2 months ago

@Jemiiah were you able to reproduce it?

Jemiiah commented 2 months ago

Yes I was @tensojka and I’ll be able to fix it by 2 days

tensojka commented 2 months ago

great, go ahead then

onlydustapp[bot] commented 2 months ago

Hey @tensojka! Thanks for showing interest. We've created an application for you to contribute to Konoha. Go check it out on OnlyDust!

Jemiiah commented 2 months ago

Great!!! @tensojka thank you