CarmineOptions / konoha

A toolkit for DAO-like governance on Starknet
Apache License 2.0
29 stars 43 forks source link

Draft for proposal.md #91

Closed raizo07 closed 3 months ago

tensojka commented 3 months ago

This only explains how to submit a custom proposal, but not how to add one, what types there are, etc. Closing. You also removed the functionality information?

raizo07 commented 3 months ago

This only explains how to submit a custom proposal, but not how to add one, what types there are, etc. Closing. You also removed the functionality information?

@tensojka Then you'll ask me to add them instead of closing the PR after all the work I have done. That is a bad look. What then happens to all the work and time I've spent on it?

tensojka commented 3 months ago

What you wrote will not be merged or used in documentation as it's faster to rewrite it from scratch to get it to an acceptable state. That you will not be able to get it to an acceptable state is a risk you took on when you requested to be assigned to the task.

We have high standards for quality of code and documentation (especially user-facing as that's often the only thing the decisionmakers will see) and these have not been met.

raizo07 commented 3 months ago

What you wrote will not be merged or used in documentation as it's faster to rewrite it from scratch to get it to an acceptable state. That you will not be able to get it to an acceptable state is a risk you took on when you requested to be assigned to the task.

We have high standards for quality of code and documentation (especially user-facing as that's often the only thing the decisionmakers will see) and these have not been met.

@tensojka I'll be sending a PR for an alternate version I wrote previously. Kindly review, if it doesn't fit the standards, then I'll hands off it.