CarmineOptions / konoha

A toolkit for DAO-like governance on Starknet
Apache License 2.0
23 stars 33 forks source link

ODHack: Fix and Complete Airdrop Tests #94

Open tensojka opened 1 month ago

tensojka commented 1 month ago

Description

The current airdrop_tests.cairo file contains quasi-broken tests, with many tests commented out. The goal is to make these tests functional. Reference the defispring repository, which contains a similar, tested contract developed based on the current airdrop contract.

Tasks

  1. Uncomment and Fix Tests in airdrop_tests.cairo

  2. Reference defispring Repository:

    • Use the defispring repository as a reference to understand the testing approach.
    • Ensure the tests in airdrop_tests.cairo exceed the robustness and coverage of those in defispring.
  3. Generate Test Data Using carmine-api-airdrop:

    • Utilize the carmine-api-airdrop to create the Merkle tree and generate proofs.
    • Use this test data in the airdrop_tests.cairo.

Resources

Acceptance Criteria

Please make sure to keep the testing structure consistent and ensure the tests are comprehensive and robust. Use functions from setup.cairo and do not duplicate them, extend if needed.

tensojka commented 1 month ago

Assigned to Nico Sanch, can you confirm?

nicosanc commented 1 month ago

Yes, I'd like to take on this assignment. Thank you for the opportunity!

TropicalDog17 commented 2 weeks ago

Hi, could I work on this issue?

I'm relatively new to Cairo, and I believe the best way to start learning a new codebase is from writing and fixing tests

tensojka commented 2 weeks ago

@TropicalDog17 Yes, good luck!