Open Carnaux opened 4 years ago
Interesting feature! IT would be interesting made some examples as user cases to show which images are better and which are not.
Perfect!
Awesome! Huge thanks, @Carnaux :+1:
I'm writing this wiki page to guide the users.
this issue can be useful for the wiki: https://github.com/Carnaux/NFT-Marker-Creator/issues/11
after you put those info on the wiki you also may close the issue :)
I've just finished the wiki! What do you think? @kalwalt @nicolocarpignoli
https://github.com/Carnaux/NFT-Marker-Creator/wiki/Creating-good-markers
That Is very good @Carnaux ! I will make a link as i said in the jsartoolkit5 README.md
for me it's super ok!
Just two point:
maybe there is in general 'too much caution' when talking about "good markers". What I mean is that while reading the Wiki, a common user may think that to create a good marker is hard and complicated, while in general most of the required variables are pretty much satisfied every time.
we can also add a quick mention to the node generator and web generator: to link them in the 'home' section will be enough.
If you'd like I can make the modifies but I don't know how to do that with the wiki.
@nicolocarpignoli to modify the wiky Just fork It as another repository 😃
yes I know but the proposed methods are not very straightforward to me: https://stackoverflow.com/questions/10642928/how-to-pull-request-a-wiki-page-on-github
I can propose some change in PVT if @Carnaux has no time for that :) Let me know
Sorry, didn't know of PR complexity for the wiki, probably better suggest changes or send a .zip file.
I will write other pages on the wiki later, and I will make the modifications
I just added a little bit of text that may help with:
a common user may think that to create a good marker is hard and complicated
Hi there! I have problem in understanding the confidence level. Two examples:
this image: https://github.com/nicolocarpignoli/nft-images/blob/master/tardis.jpg
IS recognized, and gives this confidence level:
[----- ] 0.96/5 || Entropy: 4.71 || Current max: 5.17 min: 4.6
this other image: https://github.com/nicolocarpignoli/nft-images/blob/master/room104.jpg
IS NOT recognized, and gives this confidence level:
Confidence level: [ * * * *- ] 4.3/5 || Entropy: 5.09 || Current max: 5.17 min: 4.6
I'm a bit confused @Carnaux
Hi there! I have problem in understanding the confidence level. Two examples:
this image: https://github.com/nicolocarpignoli/nft-images/blob/master/tardis.jpg IS recognized, and gives this confidence level:
[----- ] 0.96/5 || Entropy: 4.71 || Current max: 5.17 min: 4.6
this other image: https://github.com/nicolocarpignoli/nft-images/blob/master/room104.jpg IS NOT recognized, and gives this confidence level:
Confidence level: [ * * * *- ] 4.3/5 || Entropy: 5.09 || Current max: 5.17 min: 4.6
I'm a bit confused @Carnaux
I think that images are ok but maybe the problem is the resolution: tardis.jpg is 627 kb room104.jpg is 269 kb you should look also the number of imageSet and number of FeaturesPoints and compare both.
Strange, I will test it and give you feedback.
@nicolocarpignoli I tested both images, and both tracked. The Tardis image got a low score because of the color palette.
Yes it was an error of mine (not regardin marker generator). Marker generator works great. I will only make more clear the confidence score maybe?
Maybe, if confidence is under a certain treshold (2 points?) we can link on the confidence output the URL of the doc on how to choose better images.
I will search for a quick and costless feature detection algorithm, that way it will be more precise
@Carnaux did you ever find anything that is a more reliable measurement of the confidence? We are also having an issue with this.
Hi guys, thanks for adding in this feature, but I don't think its working as intended. Other than the pinball picture, any picture i upload onto the web version of the tool gives back 0/5 confidence (5 stars all greyed out). Any ideas?
Hey guys, I'm totally out of time, so I can't solve it now, when I get some free time I can try to solve it. sorry :/
@kalwalt @nicolocarpignoli @jonasjohansson With the last commit I added a confidence level based on Shannon's entropy equation. To calculate the level( 0 - 5 ) I tested with this image that gives an entropy of 4.6, I couldn't get it to be detected by my webcam so i set its entropy as the minimum (0), the maximum(5) its an entropy of 5.17 of the pinball image.
The node app logs at the end:
Confidence level: [ * * * * * ] 5/5 || Entropy: 5.17 || Current max: 5.17 min: 4.6
And the web version display stars.If you find any image that does not correspont to it's confidence level, please report in this issue!