search

Carnaux / NFT-Marker-Creator

This editor creates NFT markers for ARTOOKIT 5.x
https://carnaux.github.io/NFT-Marker-Creator/
332 stars 159 forks source link

About jpeg and future development of NFT marker creator #6

Closed kalwalt closed 4 years ago

kalwalt commented 5 years ago

We continue here the discussion started on my PR for NFT https://github.com/kalwalt/jsartoolkit5/pull/2#issuecomment-534261520 @Carnaux we can leave here our thoughts and solutions for the problem.

Carnaux commented 4 years ago

@nicolocarpignoli the node app already does the automation, it only asks to input info if the decoder can't get the EXIF info. But the c++ code has some advanced inputs, e.g the precision of the feature extraction, I will add those options later.

I just uploaded a simple page with the browser version: https://carnaux.github.io/NFT-Marker-Creator-Web/

It is not faster, but for small images is more practical.

kalwalt commented 4 years ago

@Carnaux i tried with the browser version, yes it seems it takes longer to generate the data set...

Carnaux commented 4 years ago

I just added PNG support for the node app!! It works with grayscale and RGB/RGBA images.

Edit: Also added to the browser version!

kalwalt commented 4 years ago

I just added PNG support for the node app!! It works with grayscale and RGB/RGBA images.

Edit: Also added to the browser version!

Great @Carnaux !! Thank you!

nicolocarpignoli commented 4 years ago

@Carnaux does it make sense to merge and close this PR and work directly on specific features, that solves specific issue?

Carnaux commented 4 years ago

Yes, this was just for general conversation.