Update build instructions, support for emscripten 2.0.30 and macOS

Carnaux / NFT-Marker-Creator

This editor creates NFT markers for ARTOOKIT 5.x

https://carnaux.github.io/NFT-Marker-Creator/

333 stars 160 forks source link

Update build instructions, support for emscripten 2.0.30 and macOS #82

Closed andreyrd closed 3 years ago

andreyrd commented 3 years ago

Clarified instructions on enabling ES6 modules
Updated to build on emscripten 2.0.30
Updated build instructions with macOS support

I couldn't get the Docker build to work, and ended up fixing the build on macOS using the latest version of emscripten. I have a lot more suggestions for this project in general (don't publish builds to git, use Github releases, use parameters instead of a string with flags, etc.), and I really would like to make it run much, much faster on the web, so I'm hoping to submit more PRs in the future.

kalwalt commented 3 years ago

Hi @andreyrd did you see an improvement with the newer emscripten version?

andreyrd commented 3 years ago

I don't think so, but I was finding it very difficult to get consistent results when trying to measure if there was any kind of speed improvement. It was acting strange, and the WASM version was slower than the JS version.

kalwalt commented 3 years ago

@andreyrd I used this setup https://github.com/webarkit/jsartoolkitNFT/issues/67#issuecomment-941412397 to build jsartoolkitNFT , i updated also the wiki https://github.com/webarkit/jsartoolkitNFT/wiki#recommended-build-using-docker. I think should work also for NFT-Marker-Creator.