CarnegieLearningWeb / UpGrade

Framework for adding A/B testing to education applications
https://www.upgradeplatform.org/
BSD 3-Clause "New" or "Revised" License
26 stars 13 forks source link

FF: Add Include-All toggle to the Include Table all header #1758

Closed danoswaltCL closed 1 month ago

danoswaltCL commented 1 month ago

This story is to position that switch in the include table header and wire up the basic functionality.

The user will be able to toggle the FILTER_MODE property of the flag itself by toggling an 'Include All' switch in the include table header. By default, a newly created flag will have FILTER_MODE.EXCLUDE_ALL, so it will be in the off position.

When Include-All toggle is enabled, we will pop a confirmation modal that should give a pretty clear message about what the effect will be to the include lists.

@zackcl @amurphy-cl will need a design and some word-smithing for the confirmation modal for include-all confirmation modal and the exclude-all confirmation modal

When the toggle is confirmed and we will send a PUT request to /featureflags/:id with the value FILTER_MODE.INCLUDE_ALL for on, and FILTER_MODE.EXCLUDE_ALL.

Latest design:

Image

Image

Image

Image

Image

danoswaltCL commented 1 month ago

I like the message that it sends when collapsing that we are clearly switching to "Include All" mode. But this design makes it look like we are still 'freezing' their ability to manage their lists when include all is selected, I couldn't tell from the video if there was any way for the user to still view and edit things.

@amurphy-cl for refinement tomorrow, can we answer some true or false for the user scenarios we want to support

When Include All is selected:

Yagnik56 commented 1 day ago

QA: passed as per images provides in this issue